You are not logged in.

DIY Combat Engine version 2.0

Applications: [GameMaster: OPEN] | [Volunteer Testers: OPEN]


This forum will be permanently shut down on Friday 13.07.2018
Please copy or save all important information from old forum before they will be deactivated
We have moved to new board. https://forum.runesofmagic.gameforge.com/Come join us.

CROMI80

Intermediate

Posts: 338

Occupation: Mechcanical service engineer

  • Send private message

81

Monday, November 7th 2011, 3:32pm

not reading skills.

guys i just cannot get the read skill sentence when i log in, i download DYICE 2.0 and add it into the Addons folder. dun seems to wrok for me. any pointers?
~Know no limit to unleash the untap potential in yourself
看的懂的人请来osha联络我。Leogolas

ghostwolf82

Professional

  • "ghostwolf82" started this thread

Posts: 859

Location: Kalvans Trunk

Occupation: It's dark in here

  • Send private message

82

Monday, November 7th 2011, 4:05pm

Sekrit, you are correct in that CD checks for cooldown timers on a skill. The use of "mode" is not the way he is using CD to check the skills.

Item shop pets/pet egg pets are different from class pets, and are handled differently by the code if I remember right. Too much of a time crunch before work to research more right now.

@ CROMI80 - The "Reading Skills" message no longer displays in the chat. What you will need to do is go in game, press your macro to call DIYCE, and look for a red button with a green flashing ring around it up by your minimap. Press the red button, and you will see an error message. Either figure out what the error is, or post it here for more help. (What does your in game macro look like?)

@Auros - Yeah, I didn't figure there would be any issues, but wasn't sure since some of the calls are the same.

@lordmohg - Thank you so much for finding that! I will be testing that later today. If I am able to get it working, I will post up the changes I make to get it into the main body of code. From the research I have been doing into skill/class pets, I should be able to get it to display the name of the skills instead of what it currently displays. I hope :)

CROMI80

Intermediate

Posts: 338

Occupation: Mechcanical service engineer

  • Send private message

83

Monday, November 7th 2011, 4:19pm

[LEFT] --Begin Player Skill Sequences

--Priest = AUGUR, Druid = DRUID, Mage = MAGE, Knight = KNIGHT,
--Scout = RANGER, Rogue = THIEF, Warden = WARDEN, Warrior = WARRIOR
--Class: Scout/Warden
if mainClass == "RANGER" and subClass == "WARDEN" then

--Potions and Buffs
Skill = {
{ name = "Frost Arrow", use = (not pbuffs("Frost Arrow")) },
{ name = "Briar Shield", use = (not pbuffs("Briar Shield")) },
{ name = "Entling Offering", use = (not pbuffs("Entling Offering")) },
--Combat & PVE
if enemy and (mode == "PvE") then
Skill2 = {
{ name = "Snipe", use = (pbuffs("Hidden Peril")) },
{ name = "Combo Shot", use = (CD("Combo Shot")) },
{ name = "Autoshot", use = (not ASon) },
{ name = "Vampire Arrows", use = (CD("Vampire Arrows") and (EnergyBar1 >= 30)) },
{ name = "Thorn Arrow", use = (CD("Torn Arrow")) },
{ name = "Hidden Peril", use = (CD("Hidden Peril") and (EnergyBar1 >= 30)) },
{ name = "Reflected Shot", use = (CD("Reflected Shot")) },
{ name = "Piercing Arrow", use = (CD("Piercing Arrow")) },
{ name = "Wind Arrows", use = ((CD("Wind Arrows")) and (EnergyBar1 >= 55)) },
{ name = "Shoot", use = (CD("Shoot")) },
}
--Combat & PVP
elseif enemy and (mode == "PvP") then
Skill2 = {
{ name = "Detection", use = (not pbuffs("Detection")) },
{ name = "Snipe", use = (pbuffs("Hidden Peril")) },
{ name = "Autoshot", use = (not ASon) },
{ name = "Piercing Arrow", use = (CD("Piercing Arrow")) },
{ name = "Reflected Shot", use = (CD("Reflected Shot")) },
{ name = "Vampire Arrows", use = (CD("Vampire Arrows")) },
{ name = "Thorn Arrow", use = (CD("Torn Arrow")) },
{ name = "Hidden Peril", use = (CD("Hidden Peril") and (EnergyBar1 >= 30)) },
{ name = "Combo Shot", use = (CD("Combo Shot")) },
{ name = "Wind Arrows", use = ((CD("Wind Arrows")) and (EnergyBar1 >= 35)) },
}
end
i got this error message [string'?']:4: '=' expected near 'that'[/LEFT]
~Know no limit to unleash the untap potential in yourself
看的懂的人请来osha联络我。Leogolas

CROMI80

Intermediate

Posts: 338

Occupation: Mechcanical service engineer

  • Send private message

84

Monday, November 7th 2011, 4:21pm

i use this in ingame macro

/run KillSequence("", PVE)

/run KillSequence("", PVP)
~Know no limit to unleash the untap potential in yourself
看的懂的人请来osha联络我。Leogolas

mrmisterwaa

Professional

Posts: 670

Location: Kuwait

  • Send private message

85

Monday, November 7th 2011, 4:24pm

Quoted from "CROMI80;481314"

[LEFT] --Begin Player Skill Sequences

--Priest = AUGUR, Druid = DRUID, Mage = MAGE, Knight = KNIGHT,
--Scout = RANGER, Rogue = THIEF, Warden = WARDEN, Warrior = WARRIOR
--Class: Scout/Warden
if mainClass == "RANGER" and subClass == "WARDEN" then

--Potions and Buffs
Skill = {
{ name = "Frost Arrow", use = (not pbuffs("Frost Arrow")) },
{ name = "Briar Shield", use = (not pbuffs("Briar Shield")) },
{ name = "Entling Offering", use = (not pbuffs("Entling Offering")) },
--Combat & PVE
if enemy and (mode == "PvE") then
Skill2 = {
{ name = "Snipe", use = (pbuffs("Hidden Peril")) },
{ name = "Combo Shot", use = (CD("Combo Shot")) },
{ name = "Autoshot", use = (not ASon) },
{ name = "Vampire Arrows", use = (CD("Vampire Arrows") and (EnergyBar1 >= 30)) },
{ name = "Thorn Arrow", use = (CD("Torn Arrow")) },
{ name = "Hidden Peril", use = (CD("Hidden Peril") and (EnergyBar1 >= 30)) },
{ name = "Reflected Shot", use = (CD("Reflected Shot")) },
{ name = "Piercing Arrow", use = (CD("Piercing Arrow")) },
{ name = "Wind Arrows", use = ((CD("Wind Arrows")) and (EnergyBar1 >= 55)) },
{ name = "Shoot", use = (CD("Shoot")) },
}
--Combat & PVP
elseif enemy and (mode == "PvP") then
Skill2 = {
{ name = "Detection", use = (not pbuffs("Detection")) },
{ name = "Snipe", use = (pbuffs("Hidden Peril")) },
{ name = "Autoshot", use = (not ASon) },
{ name = "Piercing Arrow", use = (CD("Piercing Arrow")) },
{ name = "Reflected Shot", use = (CD("Reflected Shot")) },
{ name = "Vampire Arrows", use = (CD("Vampire Arrows")) },
{ name = "Thorn Arrow", use = (CD("Torn Arrow")) },
{ name = "Hidden Peril", use = (CD("Hidden Peril") and (EnergyBar1 >= 30)) },
{ name = "Combo Shot", use = (CD("Combo Shot")) },
{ name = "Wind Arrows", use = ((CD("Wind Arrows")) and (EnergyBar1 >= 35)) },
}
end
i got this error message [string'?']:4: '=' expected near 'that'[/LEFT]


Please do not post code without the tags. It's extremely frustrating to read.

You need to go to Line 4 of your CustomFunctions.lua and see what is wrong.

@Ghostwolf, that is what I thought. I am also assuming, CROMI80 didn't even put an arg2.

ghostwolf82

Professional

  • "ghostwolf82" started this thread

Posts: 859

Location: Kalvans Trunk

Occupation: It's dark in here

  • Send private message

86

Monday, November 7th 2011, 4:48pm

Looks like he is using the mode arg correctly, but the cooldown checks are redundant in the code.

What does line 4 look like in your customfunctions.lua? You shouldn't have changed anything in the original code, so either you added custom functions above the SilenceList, or you edited the SilenceList (which again, you shouldn't be needing to). Also, there is no lua code for a "that", so please post what you have at line 4.

When posting code, please wrap it in [ code ] and [ /code ] tags.

Playalot

Beginner

Posts: 1

  • Send private message

87

Monday, November 7th 2011, 5:34pm

I've downloaded the .zip file and move the content (2 lua and 1 toc) to the addons folder. I've revised the custom file to match the 'Rogue/Scout' as per one of the post here. In game, I made a macro stating "/run KillSequence()" (without the quotes). However, when i execute the macro, nothing happens. No error messages, as if the macro is not loading at all. Please advise.

CROMI80

Intermediate

Posts: 338

Occupation: Mechcanical service engineer

  • Send private message

88

Monday, November 7th 2011, 5:39pm

Quoted from "ghostwolf82;481319"

Looks like he is using the mode arg correctly, but the cooldown checks are redundant in the code.

What does line 4 look like in your customfunctions.lua? You shouldn't have changed anything in the original code, so either you added custom functions above the SilenceList, or you edited the SilenceList (which again, you shouldn't be needing to). Also, there is no lua code for a "that", so please post what you have at line 4.

When posting code, please wrap it in [ code ] and [ /code ] tags.

ghost, i also trying to find that code for "that" , just could not find it.
also i took mrmisterwaa advice and did some change, now at least the buff are working. i go through my codes again. thanks for the help.
~Know no limit to unleash the untap potential in yourself
看的懂的人请来osha联络我。Leogolas

mrmisterwaa

Professional

Posts: 670

Location: Kuwait

  • Send private message

89

Monday, November 7th 2011, 5:51pm

Quoted from "Playalot;481338"

I've downloaded the .zip file and move the content (2 lua and 1 toc) to the addons folder. I've revised the custom file to match the 'Rogue/Scout' as per one of the post here. In game, I made a macro stating "/run KillSequence()" (without the quotes). However, when i execute the macro, nothing happens. No error messages, as if the macro is not loading at all. Please advise.


If you are talking about my Rogue/Scout,

You need to add my block of code to it.

If you look at my signature you can see mine and it is an edited version of the Ghostwolf's one. I also explain how to use it in a macro.

ghostwolf82

Professional

  • "ghostwolf82" started this thread

Posts: 859

Location: Kalvans Trunk

Occupation: It's dark in here

  • Send private message

90

Monday, November 7th 2011, 9:20pm

@Playalot - Did you put the 3 files into a DIYCE folder in the addons folder, or did you just drop the files directly into the addon folder? They need to be in a DIYCE folder (.../interface/addons/DIYCE)

lee9859

Beginner

Posts: 7

  • Send private message

91

Tuesday, November 8th 2011, 3:20am

Thanks for all the work on this thread...have learned lots, but not quite enough I guess...

Here is what I've added to the CustomFuntions.lua file for my Warrior/Rogue:


Source code

 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24

     elseif mainClass == "WARRIOR" and subClass == "THIEF" then
             
        --Combat
            if enemy then 
                Skill = {
        { name = "Survival Instinct",          = (health <= .49) },
        { name = "Splitting Chop",             = (enemy and (rage >= 15) and string.find(tbuffs,"Weakened")) },
        { name = "Thunder",                    = (enemy and (rage >= 15) and string.find(tbuffs,"Weakened")) },
        { name = "Open Flank",                 = ((not friendly) and (rage >= 10) and (string.find(tbuffs,"Vulnerable")) and CD("Thunder")) },
        { name = "Keen Attack",                = (enemy and (energy >= 20) and string.find(tbuffs,"Vulnerable")) },
        { name = "Probing Attack",             = (enemy and (rage >= 15)) },
        { name = "Blood Dance",                = ((enemy) and (health >= .50)) },
        { name = "Slash",                      = ((enemy) and (rage >= 25)) },
        { name = "Shadowstab",                 = ((enemy) and (energy >= 20)) },
            }
        end
  

                
            --ADD MORE CLASS COMBOS HERE. 
            --USE AN "ELSEIF" TO CONTINUE WITH MORE CLASS COMBOS.
            --THE NEXT "END" STATEMENT IS THE END OF THE CLASS COMBOS STATEMENTS.
            --DO NOT POST BELOW THE FOLLOWING "END" STATEMENT!
            end
I am getting the following errors when I attempt to use:


...../DICYE/Customfunctions.lua [string'?']:147:unexpected symbol near "="

[string 'KillSequence()']=1:attempt to call global 'KillSequence' (a nil value)

any help anyone can offer would be great!

AngelIsrafel

Intermediate

Posts: 320

  • Send private message

92

Tuesday, November 8th 2011, 3:26am

Quoted from "lee9859;481470"

Thanks for all the work on this thread...have learned lots, but not quite enough I guess...

Here is what I've added to the CustomFuntions.lua file for my Warrior/Rogue:


Source code

 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24

     elseif mainClass == "WARRIOR" and subClass == "THIEF" then
             
        --Combat
            if enemy then 
                Skill = {
        { name = "Survival Instinct",          = (health <= .49) },
        { name = "Splitting Chop",             = (enemy and (rage >= 15) and string.find(tbuffs,"Weakened")) },
        { name = "Thunder",                    = (enemy and (rage >= 15) and string.find(tbuffs,"Weakened")) },
        { name = "Open Flank",                 = ((not friendly) and (rage >= 10) and (string.find(tbuffs,"Vulnerable")) and CD("Thunder")) },
        { name = "Keen Attack",                = (enemy and (energy >= 20) and string.find(tbuffs,"Vulnerable")) },
        { name = "Probing Attack",             = (enemy and (rage >= 15)) },
        { name = "Blood Dance",                = ((enemy) and (health >= .50)) },
        { name = "Slash",                      = ((enemy) and (rage >= 25)) },
        { name = "Shadowstab",                 = ((enemy) and (energy >= 20)) },
            }
        end
  

                
            --ADD MORE CLASS COMBOS HERE. 
            --USE AN "ELSEIF" TO CONTINUE WITH MORE CLASS COMBOS.
            --THE NEXT "END" STATEMENT IS THE END OF THE CLASS COMBOS STATEMENTS.
            --DO NOT POST BELOW THE FOLLOWING "END" STATEMENT!
            end
I am getting the following errors when I attempt to use:


...../DICYE/Customfunctions.lua [string'?']:147:unexpected symbol near "="

[string 'KillSequence()']=1:attempt to call global 'KillSequence' (a nil value)

any help anyone can offer would be great!



I'm a total nub when it comes to this, but isn't the class called rogue not Theif?

Peryl

Intermediate

Posts: 313

Location: Elsewhere

  • Send private message

93

Tuesday, November 8th 2011, 3:28am

Quoted from "lee9859;481470"

...../DICYE/Customfunctions.lua [string'?']:147:unexpected symbol near "="

[string 'KillSequence()']=1:attempt to call global 'KillSequence' (a nil value)

any help anyone can offer would be great!


The first error is telling you that Lua encountered the symbol = but it shouldn't be given at this point. In short, "=" is used to assign something to some variable. So you are missing a variable.

The second error is normal and is caused by the first. Since the first error stops the definition of the function, the function KillSequence doesn't exist and therefore is nil. Fixing the first will fix the second too.

Looking at the code, we see where the error is:

Source code

 
1

        { name = "Survival Instinct",          = (health <= .49) },

note that you are missing the word use in front of the = (health <= .49).

The fixed line should be:

Source code

 
1

        { name = "Survival Instinct",        use = (health <= .49) },

Add the term use to all your other skill lines as well, since it is also missing from them.

That should clear things up.
2013... The year from hell....

Peryl

Intermediate

Posts: 313

Location: Elsewhere

  • Send private message

94

Tuesday, November 8th 2011, 3:32am

Quoted from "AngelIsrafel;481478"

I'm a total nub when it comes to this, but isn't the class called rogue not Theif?

The value returned by the game function that is being used returns strings with internal names used. They were probably called that when RW first started coding the game and only later changed the displayed text.

Internally however, they still use the old names. You'll note that the priest is internally called "AUGUR".
2013... The year from hell....

lee9859

Beginner

Posts: 7

  • Send private message

95

Tuesday, November 8th 2011, 4:39am

so the new code looks like this

Source code

 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25

elseif mainClass == "WARRIOR" and subClass == "THIEF" then
             
        --Combat
            if enemy then 
                Skill = {
        { name = "Survival Instinct",         use = (health <= .49) },
        { name = "Splitting Chop",            use = (enemy and (rage >= 15) and string.find(tbuffs,"Weakened")) },
        { name = "Thunder",                   use = (enemy and (rage >= 15) and string.find(tbuffs,"Weakened")) },
        { name = "Open Flank",                use = ((not friendly) and (rage >= 10) and (string.find(tbuffs,"Vulnerable")) and CD("Thunder")) },
        { name = "Keen Attack",               use = (enemy and (energy >= 20) and string.find(tbuffs,"Vulnerable")) },
        { name = "Probing Attack",            use = (enemy and (rage >= 15)) },
        { name = "Blood Dance",               use = ((enemy) and (health >= .50)) },
        { name = "Slash",                     use = ((enemy) and (rage >= 25)) },
        { name = "Shadowstab",                use = ((enemy) and (energy >= 20)) },
            }
        end
  

                
            --ADD MORE CLASS COMBOS HERE. 
            --USE AN "ELSEIF" TO CONTINUE WITH MORE CLASS COMBOS.
            --THE NEXT "END" STATEMENT IS THE END OF THE CLASS COMBOS STATEMENTS.
            --DO NOT POST BELOW THE FOLLOWING "END" STATEMENT!
            end
    --End Player Skill Sequences


and the error i'm getting now says [string'?']:147:attempt to compare nil with number

Thanks again for the help...trying to learn as fast as I can!

Peryl

Intermediate

Posts: 313

Location: Elsewhere

  • Send private message

96

Tuesday, November 8th 2011, 4:42am

Quoted from "lee9859;481500"

and the error i'm getting now says [string'?']:147:attempt to compare nil with number

Thanks again for the help...trying to learn as fast as I can!

It would help if you could say which is line 147.
2013... The year from hell....

ghostwolf82

Professional

  • "ghostwolf82" started this thread

Posts: 859

Location: Kalvans Trunk

Occupation: It's dark in here

  • Send private message

97

Tuesday, November 8th 2011, 4:47am

Ok, first post updated to show DIYCE v2.1. Some changes were made to the code again, this time involving the Priest Fairy Pet (from the level 50 elites), and some redundancies with the targeting system.

If you are a priest and have a fairy pet and want to use DIYCE to manage your Fairy for you, then you will use a macro like this:

Source code

 
1

/run if (not PriestFairySequence()) then KillSequence() end

This will attempt to run the Fairy function, and if nothing is to be ran in that function, attempt to run the main combat function. This new function will work for all priest combos.

@lee9859 (and Peryl) - There are some mistakes in your code that were missed other than your not having "use" in your code.

You do not need to use the enemy variable on every line, if you have already set an if/then statement to do so.

Unless you defined a "friendly" variable somewhere in your code, that check will do absolutly nothing, and is again redundant as it does the same thing as the "enemy" variable when called with a "(not enemy)". (ie.: (not enemy) = friendly / enemy = (not friendly), hope that clears that up for you.)

The new code no longer uses "string.find" at all. This has been replaced with a more efficient method of checking for buffs/debuffs. You can see a corrected version of your code below:

Source code

 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16

elseif mainClass == "WARRIOR" and subClass == "THIEF" then
    
        --Combat
        if enemy then
            Skill = {
                { name = "Survival Instinct",        use    = (health <= .49) },  --IMHO you should set this to trigger at .33 as an "OH SH!T"
                { name = "Splitting Chop",            use = (rage >= 15) and (tbuffs,['Weakened'])) },
                { name = "Thunder",                    use = (rage >= 15) and (tbuffs,['Weakened']) },
                { name = "Open Flank",                use = (rage >= 10) and (tbuffs,['Vulnerable'])) and CD("Thunder") },
                { name = "Keen Attack",                use = (energy >= 20) and (tbuffs,['Vulnerable']) },
                { name = "Probing Attack",            use = (rage >= 15) },
                { name = "Blood Dance",                use = (health >= .50) },
                { name = "Slash",                    use = (rage >= 25) },
                { name = "Shadowstab",                use = (energy >= 20) },
                    }
        end

lee9859

Beginner

Posts: 7

  • Send private message

98

Tuesday, November 8th 2011, 4:47am

sorry....line 147 is

Source code

 
1

{ name = "Survival Instinct",         use = (health <= .49) },

CROMI80

Intermediate

Posts: 338

Occupation: Mechcanical service engineer

  • Send private message

99

Tuesday, November 8th 2011, 4:54am

Auto target not working

Ghost and especially mrmisterwaa thanks for the advice on my codes, its working now and no errors appear.
Ghost I have a question my auto target does not seems to be working . Need some pointers.
Do I need to inclue the auto target in the macro;
/run killsequence( "",arg2,autotarget) ?? To make autotarget to work?
~Know no limit to unleash the untap potential in yourself
&#30475;&#30340;&#25026;&#30340;&#20154;&#35831;&#26469;osha&#32852;&#32476;&#25105;&#12290;Leogolas

lee9859

Beginner

Posts: 7

  • Send private message

100

Tuesday, November 8th 2011, 5:11am

Source code

 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16

elseif mainClass == "WARRIOR" and subClass == "THIEF" then
    
        --Combat
        if enemy then
            Skill = {
                { name = "Survival Instinct",        use    = (health <= .49) },  --IMHO you should set this to trigger at .33 as an "OH SH!T"
                { name = "Splitting Chop",            use = (rage >= 15) and (tbuffs,['Weakened'])) },
                { name = "Thunder",                    use = (rage >= 15) and (tbuffs,['Weakened']) },
                { name = "Open Flank",                use = (rage >= 10) and (tbuffs,['Vulnerable'])) and CD("Thunder") },
                { name = "Keen Attack",                use = (energy >= 20) and (tbuffs,['Vulnerable']) },
                { name = "Probing Attack",            use = (rage >= 15) },
                { name = "Blood Dance",                use = (health >= .50) },
                { name = "Slash",                    use = (rage >= 25) },
                { name = "Shadowstab",                use = (energy >= 20) },
                    }
        end
Thank you both for all of the help, I know that I am very newb at all this and appreciate the patience.

Current error says that it is looking for a ")" by "," in line 148, which is the Splitting Chop line. Syntax looks different than in the Thunder line, but same as Open Flank line, so not sure what to change.