You are not logged in.

Applications: [GameMaster: OPEN] | [Volunteer Testers: OPEN]


This forum will be permanently shut down on Friday 13.07.2018
Please copy or save all important information from old forum before they will be deactivated
We have moved to new board. https://forum.runesofmagic.gameforge.com/Come join us.

scanderson

Central Scrutinizer

Posts: 87

Location: New York, New York

  • Send private message

1,081

Friday, April 19th 2013, 4:55pm

Gaaaah! I think I typed KillSequence, LOL. I'll check when I get home from work. Thanks Auros! My eyes are tired from too much product dev this week.

I am pretty sure I copied it in directly from this site though, so it still isn't working if that's the case. Anyone else havign "out of the box" problems with the code?

Auros

Professional

Posts: 1,360

Mood: Mellow

  • Send private message

1,082

Friday, April 19th 2013, 6:46pm

yes, as it is published, with my Wl/R, using ghostwolfs unaltered code. Without target when I click the macro I get, attack.....attack....attack, everytime I click without moving. If I target a mob i get, Idle...Idle...Idle etc., everytime i click on the macro. My macro i use to initiate is /run KillSequence (v2, dps) and /run KillSequence (v2, QuickKill)
Govinda P/W/K/M 100x4 :pump:
Wl/R/M/Ch 100x4 :borg:
Wd/W/S 100/100/100
W/M 100/100 Glass Cannon: oh gawd, not again :pinch: ... and numerous others Semi-retired :pillepalle:

scanderson

Central Scrutinizer

Posts: 87

Location: New York, New York

  • Send private message

1,083

Friday, April 19th 2013, 6:56pm

THanks Auros,

So just so I understand you correctly, you ARE having issues when you initiate an attack on a mob that has already been targeted by you, but not when you use the macro and nothing is targeted?

ghostwolf82

Professional

  • "ghostwolf82" started this thread

Posts: 859

Location: Kalvans Trunk

Occupation: It's dark in here

  • Send private message

1,084

Friday, April 19th 2013, 6:57pm

@Auros - Try /run KillSequence("v2","QuickKill") instead, and report back what happens.

@scanderson - make sure you do in fact have the proper macro set up, and then let us know what the results are.

Edited - thanks RoMage!

RoMage

rustyx is lame rogue

Posts: 2,694

Location: web

Occupation: DB Admin

Mood: Unsure

  • Send private message

1,085

Friday, April 19th 2013, 7:21pm

Missing " before quickKill wolf.

scanderson

Central Scrutinizer

Posts: 87

Location: New York, New York

  • Send private message

1,086

Friday, April 19th 2013, 8:49pm

@ghostwolf82 - will do and thank you. Just to confirm - for testing purposes with your Curse version, I can just use:

/run KillSequence()

Correct?

Auros

Professional

Posts: 1,360

Mood: Mellow

  • Send private message

1,087

Friday, April 19th 2013, 9:00pm

Quoted from "scanderson;598562"

THanks Auros,

So just so I understand you correctly, you ARE having issues when you initiate an attack on a mob that has already been targeted by you, but not when you use the macro and nothing is targeted?



No, it does not work either way. And GW, I will try adding the quotes tonight.
Govinda P/W/K/M 100x4 :pump:
Wl/R/M/Ch 100x4 :borg:
Wd/W/S 100/100/100
W/M 100/100 Glass Cannon: oh gawd, not again :pinch: ... and numerous others Semi-retired :pillepalle:

ghostwolf82

Professional

  • "ghostwolf82" started this thread

Posts: 859

Location: Kalvans Trunk

Occupation: It's dark in here

  • Send private message

1,088

Saturday, April 20th 2013, 12:47am

@scanderson - Correct.

scanderson

Central Scrutinizer

Posts: 87

Location: New York, New York

  • Send private message

1,089

Saturday, April 20th 2013, 12:48am

OK, just confirmed it, I have the correct macro for testing (to the best of my knowledge): /run KillSequence().

The most recent DIYCE.lua file works with my old CustomFunctions. The new CustomFunctions file does not appear to work at all for me. Anything I should do to trouble-shoot? I am not getting any error messages. It may be some issue with the Rogue/Scout section, only Mrmisterwaa's customfunctions appear to work for me.

Thanks!

scanderson

Central Scrutinizer

Posts: 87

Location: New York, New York

  • Send private message

1,090

Saturday, April 20th 2013, 5:25pm

OK, folks. Here's where I stand:

1. I can't get out-of-the-box DIYCE customs functions to work for me at all, nor can I test it using the KillSequence() macro

2. I have gone line-by-line of the customfunctions code and compared it to the working code I have (based on Mrmisterwaa's R/S custom functions)

3. The code is about 80% identical, and I have tried to replicate the functions from my existing customfunctions into the newest custom functions, paying careful attention to the code formatting.

4. Mrmisterwaa's custom functions uses a goat2 action that is not found in the newest version. I believe the newest version uses "mode". I have tried to adapt to the new custom functions, but no luck.

5. The good news is that my current customfunctions does work with the newest diyce.lua file, but ironically the newest customfunctions doesn't work!

I can't figure out what is going wrong. I'll keep plugging away, but any further help would be appreciated!

Thanks.

ghostwolf82

Professional

  • "ghostwolf82" started this thread

Posts: 859

Location: Kalvans Trunk

Occupation: It's dark in here

  • Send private message

1,091

Saturday, April 20th 2013, 8:49pm

Do you have two DIYCE folders? Or two CustomFunctions.lua files?

If so then they could be conflicting with one another. Try removing your old diyce folder, or old customfunctions.lua (put it in your mydocs folder for now), and then try the macro in game with the current diyce from curse.

scanderson

Central Scrutinizer

Posts: 87

Location: New York, New York

  • Send private message

1,092

Sunday, April 21st 2013, 12:07am

No, I have been careful to segregate all files out so there will be no conflict. I suspect the problem is the 20% or so additional new code you have in the custom functions. It might be the ammo check or other items. I'll try removing each one-by-one and see.

For now - do you have any test macros for KillSequence I could try with my R/S? As I said, /run KillSequence() doesn't work at all with the files I downloaded from Curse today.

I wonder why Mrmisterwaa's customfunctions works and the stock one doesn't? So bizzare. I must be missing something, but it puzzles me that I can't do the basic KillSequence test. Maybe it has something to do with R/S?

I did have to change a skill for bleed to reflect an elite, which isn't in your customfunctions, but other than that, it should work - but doesn't. I'm pretty certain I'm not the only R/S that this doesn't work for, so I will try to debug it to the best of my ability and let you know my findings. Let me know if there is anything you need me to do to test it further.

Thanks again for following up. I really appreciate your help in all this.

ghostwolf82

Professional

  • "ghostwolf82" started this thread

Posts: 859

Location: Kalvans Trunk

Occupation: It's dark in here

  • Send private message

1,093

Sunday, April 21st 2013, 1:12am

The one up on curse right now has the functionality for using the Rune War Bow to make arrows. If you do not have this bow in your inventory, that may cause some issues.

Food and speed potion are in my script, also might cause issues.

Other than that, not sure what would be causing this issue for you. Check these things, and if those aren't it then yeah, just debug to the best of your ability letting us know what is going on along the way. I personally haven't played R/S in a very long time.

1,094

Sunday, April 21st 2013, 1:53am

Quoted from "ghostwolf82;597850"

DIYCE.lua has the updates. You need the timers to determine if YOU cast the bleed or if it was someone else. Without the timers, you will see a bleed cast by someone else, and skip shadowstab thus lowering your DPS. So remove them if you figure out how, but know that if you do, no one will want you in endgame due to the fact you will have far less dps than rogues that use the timers.


As far as rog and shadowstab, you WANT to skip shadowstab if another rog used it or blind spot, save your energy for a higher dps skill. Other rog's bleeds work for wound attack. I never use shadowstab if another rog used it first. But i do try to use blind spot instead everytime its up. i use a 6sec timer for blindspot incase im not behind or i get that msg must be behind target spammed.

1,095

Sunday, April 21st 2013, 3:16am

Source code

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
if mainClass == "THIEF" and subClass == "RANGER" then
                -- (tbuffs[500654]) = Shadowstab Bleed
                -- (tbuffs[500704]) = Low Blow Bleed
                Skill = {
                { name = "Combat Master",                     use = ((EnergyBar2 >= 30) and (not pbuffs['Combat Master']) and (not pbuffs['Hide'])) },
                { name = "Premeditation",                     use = ((EnergyBar1 >= 75) and (not combat)) },
                                }
                                
                if enemy then
                Skill = {
                    { name = "Throat Attack",                   use = (silenceThis) },
                    { name = "Wound Attack",                    use = ((EnergyBar1 >= 35) and (tbuffs['Grievous Wound'])) },
                    { name = "Energy Thief",                      use = ((EnergyBar1 <= 50) and (boss) and (combat)) },
                    { name = "Low Blow",                        use = (EnergyBar1 >= 25) and (pbuffs['Energy Thief']) and ((tbuffs['Bleed)']) or (tbuffs['Blind Spot Bleed'])) },
                    { name = "Low Blow",                        use = ((EnergyBar1 >= 45) and ((tbuffs['Bleed']) or (tbuffs['Blind Spot Bleed']) or (tbuffs['Sneak Attack Bleed']))) },
                    { name = "Shadowstab",                      use = ((EnergyBar1 >= 20) and ((not tbuffs['Bleed']) and (not tbuffs['Blind Spot Bleed']) and (not tbuffs['Sneak Attack Bleed']))) },
                    { name = "Low Blow",                          use = (EnergyBar1 >= 40) },
                    { name = "Shot",                              use = (true) },
                    { name = "Vampire Arrows",                  use = (true) },
                    { name = "Joint Blow",                      use = (EnergyBar2 >= 20) },
                                 }
                end


Rogue/scout diyce that I wrote up, havent really fully tested it yet. Doesn't include throw/combo throw, those should be able to be manualled anyways. Do what you will with it, not playing rogue anymore so not really getting any use. No need for any timers or ID's, things should work as is.

Ravesden, D/S/Wd 80/75/62
Retired. Click siggy for old RoM vids, among other things.

Auros

Professional

Posts: 1,360

Mood: Mellow

  • Send private message

1,096

Sunday, April 21st 2013, 8:17pm

Quoted from "ghostwolf82;598712"

The one up on curse right now has the functionality for using the Rune War Bow to make arrows. If you do not have this bow in your inventory, that may cause some issues.

Food and speed potion are in my script, also might cause issues.

Other than that, not sure what would be causing this issue for you. Check these things, and if those aren't it then yeah, just debug to the best of your ability letting us know what is going on along the way. I personally haven't played R/S in a very long time.

OK, got it to work, sort of. Starting with as-downloaded DIYCE 2.0 on my W/R, no other add-ons.


First error I got was [string 'if not UnitisPlayer('target') then targetUni..']:1: attempt to call global 'targetUnit' (a nil value). I searched for the term targetUnit in customfunctions and the only hit was in the last section on seige war. rather than trying to figure out adding in the local function I just commented out teh whole seige war section.


The next error was [string '?']:377:attempt to concatenate local 'Healslot' (a nil value). Line 377 is in the W/R section...I'm on W/R so good. I commented out teh lines calling for action:"..Healslot, and for good measure the one for action: "HotSlot, too, anticipating the next error.


Now, why, this works for me, I don't know. Just happy to have it working.
Govinda P/W/K/M 100x4 :pump:
Wl/R/M/Ch 100x4 :borg:
Wd/W/S 100/100/100
W/M 100/100 Glass Cannon: oh gawd, not again :pinch: ... and numerous others Semi-retired :pillepalle:

ghostwolf82

Professional

  • "ghostwolf82" started this thread

Posts: 859

Location: Kalvans Trunk

Occupation: It's dark in here

  • Send private message

1,097

Monday, April 22nd 2013, 2:30am

The reason for the errors in the W/R section are because you don't have anything set up for those skills. HoTslot is for Tourniquet, while Healslot is for Spirit Essence (healing skill from the dalanis set) - both skills are useful to a W/R since you have no natural healing skills outside of potions.

Auros

Professional

Posts: 1,360

Mood: Mellow

  • Send private message

1,098

Monday, April 22nd 2013, 4:58pm

Cool Beans...Thanks, thought it was something missing...yeah, more healing options would be nice. Now why the error on targetunit? This toon does not seige, but that error should not be localized. The Warlock did seige last night, but I don't use DIYCE in seige, so did not notice any errors...darn should have thought of that and tested.
Govinda P/W/K/M 100x4 :pump:
Wl/R/M/Ch 100x4 :borg:
Wd/W/S 100/100/100
W/M 100/100 Glass Cannon: oh gawd, not again :pinch: ... and numerous others Semi-retired :pillepalle:

scanderson

Central Scrutinizer

Posts: 87

Location: New York, New York

  • Send private message

1,099

Monday, April 22nd 2013, 5:21pm

Making Progress - Still some issues

Glad to hear that you had some success Auros. Also thanks to Ravesden for providing his code. I am starting to think the timers are interferring quite a bit with the targettiing, but I need to confirm it through more testing.

As I said earlier, I have gone through the customfunctions code for the latest version from Curse and slowly but surely made upgrades to my existing customfunctions which I adapted. My melee function is still problematic:

Source code

1
2
3
4
5
6
7
8
9
10
11
 if ((enemy) and (goat2 == "1")) then
            Skill2 = {
                { name = "Wound Attack",                       use = ((EnergyBar1 >= 35) and ((tbuffs[500654]) and (tbuffs[500704]))) },
                { name = "Blind Spot",                         use = (((EnergyBar1 >= 25) and (boss) and (behind)) and (pbuffs['Energy Thief'] or pbuffs['Premeditation'])) },
                { name = "Shadowstab",                         use = (EnergyBar1 >= 20),       timer = "SSBleed" },
                { name = "Low Blow",                           use = (((EnergyBar1 >= 25) and (tbuffs[500654])) or (tbuffs['Energy Thief'])),      timer = "LBBleed",   ignoretimer = not tbuffs['Energy Thief'] },
                { name = "Throat Attack",                      use = ((EnergyBar2 >= 50) and (boss or elite) and (silenceThis)) },
                { name = "Vampire Arrows",                     use = (EnergyBar2 >= 20) },
                { name = "Wrist Attack",                       use = ((EnergyBar2 >= 50) and (boss)) },
                { name = "Shot",                               use = ((EnergyBar1 < 20 )) },
                    }


Targeting seems to fail sometimes for certain targets and is generally just not consistent. This is particularly problematic with siege - which can cost me my life, LOL. I will try removing the timers from the code to see if that fixes it or improves it. My ranged script works flawlessly everytime and has no timers so I will use the process of elimination to test it further.

I removed the whole "fairy" code since I don't have any use for that with my class combos. It didn't break anything by removing it. And I have been slowly replacing things and then testing each replacement to make sure it works. SO far so good, but lots more to test.

A quick question (hopefully) - can anyomne explain the references to "boss" and "boss or elite" and how that affects the script? I haven't quite wrapped my head around those codes and it would be helpful to understand what they are supposed to be doing.

In short, it's a lot of work for me to get DIYCE running the way I want it, but I think I am making progress!

Thanks.

ghostwolf82

Professional

  • "ghostwolf82" started this thread

Posts: 859

Location: Kalvans Trunk

Occupation: It's dark in here

  • Send private message

1,100

Monday, April 22nd 2013, 6:25pm

@All - I test all the code I put into DIYCE before ever putting it out to you guys. Everything in the code works in game the exact way it should. If you are having errors with any parts of it, then my best guess is there is something in either your code or another addon conflicting with DIYCE operations.

@Auros - No Idead why the targeting is giving you issues. It shouldn't be. Reference the above statement.

@scanderson - Reference the above statement for starters. If you don't need/use the fairy code it wouldn't hurt you to have it, but also doesn't change anything when you remove it. Timers have nothing to do with targeting. The statements for timers in the targeting sections are cancelling the timers that are running if the target dies before your timers run out. The boss and the elite locals are there to be used for whenever you are up against such. For example, you go into an instance, and want to only use certain buffs when fighting bosses, but not against the rest of the trash in the instance (i.e. A mage would only want to use Intensification against a boss).

Still glad to see you are learning and continuing to try :)