? updating InstanceMapFix

Intermediate

Tuesday, February 7th 2012, 11:27am

Been trying to "fix" InstanceMapFix - which I like more than WowMaps,
(http://rom.curseforge.com/addons/instance-map-fix/ http://www.curse.com/addons/rom/instance-map-fix) but it's not working. It hasn't been updated for Ch 4 coz the owner no longer plays... no big deal, coz Ch 4 Instance Maps load in the game WITHOUT any addons needed EXCEPT with the addon installed to view pre-Ch4 ones, then Ch 4 Instance Maps load a black screen lol.

InstanceMapFix is still needed for pre-Ch 4 Instance Maps to load otherwise it just shows the map of Candara. Don't wanna have to keep using WowMapsInstances for just Ch 4 maps coz I'm trying to decrease the amount of addons I have lol.

So to fix this, I need the to add Ch 4 stuff to the "local mapOverride" section at the top..but where do I find the # & the location or whatever the pt/rw (I'm assuming it's rw) is? Is it thru the FDB Extractor or whatever? O_o

The original code that vEEcEE/Valacar made:

Quoted

--[[
local mapOverride = {
[119] = "pt", -- Lair of the Demon Dragon [dgn_dragons_nest]
[120] = "pt", -- Zurhidon Stronghold [dng_naga_acropolis_zurhidon]
[122] = "rw", -- Hall of the Demon Lord [dgn_naga_acropolis_lair] (requires reloading of

version 3.0.1 or higher)
}
]]

function WorldMapFrame_SetWorldMapID( MapID )

if( WorldMapFrame.mapID == MapID )then
return;
end

ZoneName = GetZoneEnglishName( MapID );

if( not ZoneName )then
HideUIPanel( WorldMapFrame );
return;
end

SetWorldMapID( MapID );
WorldMapFrame.mapID = MapID;

local imageLocation

-- change image location folder to a locale with a correct dungeon map
ZoneName = ZoneName:lower()
if ZoneName:find("dgn_") or ZoneName:find("dng_") then
--imageLocation = mapOverride[MapID] or "rw"

local f = loadfile("interface/addons/WoWMapInstances/WoWMapInstances.lua")

-- detect WoWMapInstances addon
if type(f) == "function" then
imageLocation = "interface/addons/WoWMapInstances" -- use maps

from WoWMapInstances
else
imageLocation = "interface/worldmap/rw" -- use rw (runewaker) maps
end

else
imageLocation = "interface/worldmap/" .. GetImageLocation( "WORLDMAP" ) --

original default behavior for non-dungeon maps
end

--WorldMapFrameTitleetText(imageLocation)

for i = 1,12 do
local WorldMapTexture = getglobal( "WorldMapViewFrame_WorldMapTexture_"

.. i );
WorldMapTextureetFile( imageLocation .. "/" .. ZoneName .. "/" .. i );
end

ZoneName = GetZoneLocalName( WorldMapFrame.mapID );
WorldMapSelectMapButtonetText( ZoneName );

end

-- /run for i=1,50000 do local x = GetZoneEnglishName(i) if x then echo(string.format("[%d] %s (%

s)", i, GetZoneLocalName(i), x)) end end

(¯`v´¯)
`*.¸.*´
¸.•´ ¸.•*¨) ¸.•*¨)
(¸.•´ (¸.• (¸.•´¸¸.•¨¯`•.¸¸.♥

(◕‿◕) \(●̮̮̃•̃)/ ღ~*•..¸˛.•*¨*•.¸Osha + Grimdal + Siochain = Home Sweet Home ¸.•*¨*•.˛¸.•*~ღ \(●̮̮̃•̃)/ (◕‿◕)

Go to the top of the page

TellTod

Beginner

Posts: 0

2

Friday, March 2nd 2012, 10:24pm

(first off: I'm the maintainer of WoWMap & co)

the problem is:
"if ZoneName:find("dgn_") or ZoneName:find("dng_") then"

This was correct for the old ch3 zones 'cause the rom-artists were too lazy to translate all dungeon map and just copy&paste the candara map. The original maps still exist in the developer sub-folder "rw".
With ch4 the artists got the knowledge how to translate maps and did it. So the new maps exists only in the localized sub folders and not the rw-folder.

What does it means for "InstanceMapFix":
the old "if name contains 'dng_' use the 'rw-folder' " doesn't work anymore. It needs to be replaced by a complicated one (based on the out-commended "mapOverride").

I would recommend to take a look at "WoWMap/overrides/" these lists are script generated and are doing something like "mapOverride" was planed for.

Btw: the complete WoWMapInstances part in InstanceMapFix is invalid and useless. It should be removed or needs a total rewrite

Go to the top of the page

EscapeTheFate03

Intermediate

Posts: 366

3

Saturday, March 3rd 2012, 2:52am

ya I figured it had something to do with "rw" but wasn't sure what...
a while ago I edited it & added

Quoted

[137] = "rw", -- Grafu Castle [dgn_graf_castle]
[139] = "rw", -- Sardo Castle [dgn_sardo_bastille]
[142] = "rw", -- Tomb of the Seven Heroes [dgn_tomb_of_seven_heroes]

at the top part of the code, but it doesn't fix the problem... the numbers are "right" but ur explanation explains why the "rw" was the faulty aspect of it & not even part of the equation, lol, thx for explaining & pointing that out =)

Hmm so instead of that, it would just be "i[COLOR=black ! important]nterface/worldmap/" or just completely empty or what would the "localized sub folders" be...or am I totally misreading what's said O_o I did take a look at WoWMaps' coding a while back, that's how I got the zone numbers, whatnot.

As for [/COLOR]WoWMapInstances supposed to work with InstanceMapFix...my client that was patched from Ch2 needed WoWMapInstances to make InstanceMapFix to work to show pre ch4 maps. But my client that was patched from Ch4 works without WoWMapInstances in showing pre ch4 maps.

I originally liked InstanceMapFix more coz it was more simplier and only has 2 files whereas WowMaps has like 100 files or so O_o hehe

(¯`v´¯)
`*.¸.*´
¸.•´ ¸.•*¨) ¸.•*¨)
(¸.•´ (¸.• (¸.•´¸¸.•¨¯`•.¸¸.♥

(◕‿◕) \(●̮̮̃•̃)/ ღ~*•..¸˛.•*¨*•.¸Osha + Grimdal + Siochain = Home Sweet Home ¸.•*¨*•.˛¸.•*~ღ \(●̮̮̃•̃)/ (◕‿◕)

Go to the top of the page

TellTod

Beginner

Posts: 0

4

Sunday, March 4th 2012, 1:19am

sry didn't get your question.

- WoWMapInstances v4 was a totally rework and instancemapfix didn't followed it
- if you want to use the "correct" map you have to check map-ID and check if the map is provided by your client or if you have to use a map of another client (this is the 'look at wowmap/overrides" part")

I'll help if I can..just keep in mind that I prefer WoWMap - and here we could start an irrelevant disscussion

Go to the top of the page

EscapeTheFate03

Intermediate

Posts: 366

5

Monday, March 5th 2012, 3:42am

hmm i assumed the map-ID was whatever the # was before the dgn part...
the maps r provided for the client 4.0 for pre-ch4 instance maps in the rw folder (they werent provided in the client 2.0 version, hence I had to use WoWMapInstances also, but I don't use WoWMapInstances anymore when I use client 4.0) & the ch4 instance maps is correctly placed where having no addon actually shows the ch4 maps.
hmm guess I'll have to run the FDB Extractor program to know where "[COLOR=black !important]localized sub folders" are or r they in the pt folder or whatever LODD & ZS is apart of? O_o[/COLOR]
hmm maybe add to the middle part

Quoted

[COLOR=black !important]
else
imageLocation = "interface/"
end[/COLOR]

but then again not rly sure what localized sub folders is xD... thx 4 ur explanations =)

(¯`v´¯)
`*.¸.*´
¸.•´ ¸.•*¨) ¸.•*¨)
(¸.•´ (¸.• (¸.•´¸¸.•¨¯`•.¸¸.♥

(◕‿◕) \(●̮̮̃•̃)/ ღ~*•..¸˛.•*¨*•.¸Osha + Grimdal + Siochain = Home Sweet Home ¸.•*¨*•.˛¸.•*~ღ \(●̮̮̃•̃)/ (◕‿◕)

Go to the top of the page

TellTod

Beginner

Posts: 0

6

Monday, March 5th 2012, 9:20am

here is a snapshot of current WoWmap-EN

Source code

WoWMap.MapData.Overrides={
  [101]={uselanguage="rw"}, -- dgn_cavern_of_trials
  [102]={uselanguage="rw"}, -- dgn_forlorn_monastary
  [103]={uselanguage="rw"}, -- dgn_reliquary_of_reflections
  [104]={uselanguage="rw"}, -- dgn_mystic_altar
  [105]={uselanguage="rw"}, -- dgn_kalturok_queen_chamber
  [106]={uselanguage="rw"}, -- dgn_borsburs
  [107]={uselanguage="rw"}, -- dgn_kleeon_temple
  [108]={uselanguage="rw"}, -- dgn_the_treasure_trove
  [110]={uselanguage="rw"}, -- dgn_wretched_grotto
  [114]={uselanguage="rw"}, -- dgn_mulgrum_relic
  [115]={uselanguage="rw"}, -- dgn_echoes_of_the_sea
  [116]={uselanguage="rw"}, -- dgn_the_origin
  [117]={uselanguage="rw"}, -- dgn_hall_of_survivors
  [118]={uselanguage="rw"}, -- dgn_moonspring_hollow
  [119]={uselanguage="rw"}, -- dgn_dragons_nest
  [120]={uselanguage="rw"}, -- dgn_naga_acropolis_zurhidon
  [122]={uselanguage="rw"}, -- dgn_naga_acropolis_lair
  [127]={uselanguage="rw"}, -- dgn_daelanis_jail
  [129]={uselanguage="rw"}, -- dgn_venadurken_arena
  [130]={uselanguage="rw"}, -- dgn_pesche_temple
  [134]={uselanguage="rw"}, -- dgn_kafkes_tomb
  [201]={uselanguage="rw"}, -- tiledgn_bloody_gallery
  [205]={uselanguage="rw"}, -- tiledgn_hybora_labyrinth_01
  [206]={uselanguage="rw"}, -- tiledgn_hybora_labyrinth_02
  [207]={uselanguage="rw"}, -- tiledgn_hybora_labyrinth_03
  [208]={uselanguage="rw"}, -- dgn_varanas_dreamscape
  [210]={uselanguage="rw"}, -- dgn_menorca_empire_ruins
  [250]={uselanguage="rw"}, -- tiledgn_windmill_basement
  [251]={uselanguage="rw"}, -- tiledgn_laskotar_arcane_chamber
  [252]={uselanguage="rw"}, -- tiledgn_citadel_agriza
  [113]={usezone=114}, -- dgn_mulgrum_relic_easy (fallback for RoM Bugs)
  [123]={usezone=117}, -- dgn_hall_of_survivors_easy (fallback for RoM Bugs)
  [126]={usezone=115}, -- dgn_echoes_of_the_sea_easy (fallback for RoM Bugs)
  [128]={usezone=127}, -- dgn_daelanis_jail_easy (fallback for RoM Bugs)
  [131]={usezone=129}, -- dgn_venadurken_arena_easy (fallback for RoM Bugs)
  [132]={usezone=130}, -- dgn_pesche_temple_easy (fallback for RoM Bugs)
  [133]={usezone=130}, -- dgn_pesche_temple_hard (fallback for RoM Bugs)
  [135]={usezone=134}, -- dgn_kafkes_tomb_easy (fallback for RoM Bugs)
  [136]={usezone=137}, -- dgn_graf_castle_hard (fallback for RoM Bugs)
  [138]={usezone=137}, -- dgn_graf_castle_easy (fallback for RoM Bugs)
  [140]={usezone=139}, -- dgn_sardo_bastille_easy (fallback for RoM Bugs)
  [141]={usezone=142}, -- dgn_tomb_of_seven_heroes_hard (fallback for RoM Bugs)
  [143]={usezone=142}, -- dgn_tomb_of_seven_heroes_easy (fallback for RoM Bugs)
}

NB: While client patching the RW folder isn't transfered. So sometimes a fresh-full-installation is required
WoWMap-instance is only required if using a patched or a slim-client installation.

NB2: you can ignore the "usezone" fallbacks; I'm not sure if they are still needed

Go to the top of the page

Runes of Magic US / AU