You are not logged in.

Applications: [GameMaster: OPEN] | [Volunteer Testers: OPEN]


This forum will be permanently shut down on Friday 13.07.2018
Please copy or save all important information from old forum before they will be deactivated
We have moved to new board. https://forum.runesofmagic.gameforge.com/Come join us.

1

Monday, July 2nd 2012, 2:20pm

GCI + Party Frame Bug

I've only seen this mentioned in one other thread, and that was on the EU forum (and it was two months ago), so I figured I'd ask here in case anyone's found an answer or a fix.

Since I came back, I've noticed a very irritating bug with the party frame with GCI. My boyfriend came back when I did too, and he's having the same issue. Any time we're in a raid party, the standard party interface doesn't disappear unless we manually disable it in the GCI settings menu.

Is this a relatively new bug, and if so, is it fixable? And is this happening to everyone, or is it just a few people? It's not terribly game-breaking, but it is very annoying to have to go into the GCI menu every single time I join a party, and then to have to re-enable the party interface afterward.

Any help would be very much appreciated. :D

Formerly Catorii, D/S/M of Faction.


2

Monday, July 2nd 2012, 7:11pm

it has been happening to me since xmas

3

Monday, July 2nd 2012, 8:52pm

This is one of the reasons I had to get rid of Gridcliqueit, cause it was interfering with Ikarus and keeping that party frame up no matter what.

Wish it could be fixed... cause I loved GCI.
Borella - 100 W/M/S/R/P/K
VVV
If you play P/K in instances you're garbage


4

Tuesday, July 3rd 2012, 1:13am

Glad to hear it's not just us, but it's a shame that this bug popped up. I'm still using it since it really does increasing healing efficiency (and I'm not using Ikarus anymore), but it's so irritating to have to do this all manually with every party x_x.

We tried the trick that someone on the EU forums suggested (making raid settings different than party settings), but no dice. Still acted up unless we went into GCI and clicked "save" again. Which defeats the purpose of having separate settings anyway. :(

I really hope someone can get this add-on to work properly again. It's definitely my favorite by far.

Formerly Catorii, D/S/M of Faction.


Peryl

Intermediate

Posts: 313

Location: Elsewhere

  • Send private message

5

Tuesday, July 3rd 2012, 3:22am

Hmmm... I took a peek at this problem but as I can't test anything, I can't be 100% sure what the cause or solution is. However, it looks like it might be a synchronization problem with saved/changed settings and what it thinks are the current/loaded settings.

As a first attempt try the following:

Open the file GridCliqueIt_Config.lua and search for Sol.config.CheckSettings.
Add the following to the end of this function (right before the word end that starts at the far left, a couple of lines below)

Source code

1
   GridCliqueIt.SaveConfig()

The end of the function should now look like this:

Source code

1
2
3
4
   Sol.config.CheckSettings("GridCliqueIt", defaultSettings)
   GridCliqueIt.Settings_Temp = GridCliqueIt.Copy(GridCliqueIt_Settings)
   GridCliqueIt.SaveConfig()
end


This should force the settings to be re-saved and should sync things properly. Again, I can't be 100% sure of this, but as it is a single line change, may be worth attempting.
2013... The year from hell....

6

Tuesday, July 3rd 2012, 4:01am

Well, that partially fixed the issue. It's more bearable now, since if I join an already-made raid, the party UI will pop up for only a split-second before disappearing. It still doesn't fix the bug with it not disappearing if you're in a party before it's made into a raid, but that's not as big of a deal. Thanks so much for looking at this, Peryl. :)

Formerly Catorii, D/S/M of Faction.


Peryl

Intermediate

Posts: 313

Location: Elsewhere

  • Send private message

7

Tuesday, July 3rd 2012, 5:00am

Well that's good to know. So if it also acts up when in a party, I'll see if there is some other place the settings need synching. I'll also see if I can get it to not show the frames for the brief period of time.

When you are in a party, are the party frames supposed to be on?

Edit:
Well I haven't even finished my morning coffee yet, so the brain may still be a little muddled but try this:

Again in GridCliqueIt_Config.lua, search for function GridCliqueIt.ConfigCheckLoad(). Modify the function so that it looks like this (just add the last two lines before the end statement):

Source code

1
2
3
4
5
6
7
8
function GridCliqueIt.ConfigCheckLoad()
   GridCliqueIt.LoadSliders()
   GridCliqueIt.LoadCheckBoxes()
   GridCliqueIt.LoadEditBoxes()

   GridCliqueIt.HideParty()
   GridCliqueIt.HidePlayer()
end

The added function calls, despite their names, don't just hide the frames but toggle them on/off depending on the desired state in the settings.

I think this may help the situation. Let me know.

Edit 2:
In case you don't have it, check this thread for a modification to GCI to account for the new classes.
2013... The year from hell....

8

Tuesday, July 3rd 2012, 4:21pm

I'll try that now, thanks! And yes, when I'm just in a normal party, the party interface should be on. The problem now is just getting it to hide when someone turns said party into a raid (i.e. you see the normal 6-person party UI underneath the raid UI).

Formerly Catorii, D/S/M of Faction.


Peryl

Intermediate

Posts: 313

Location: Elsewhere

  • Send private message

9

Tuesday, July 3rd 2012, 5:32pm

Just noticed something in the code that might be the root cause of all this (making the previous changes possibly redundant). There appears to be a couple of default settings missing specifically for hiding/showing the standard UI. If in a raid and the "Separate Raid Settings" option is on, this would make the code want to show the UI while in a raid (note that the Separate Raid option must be on).

Anyway, to add these default settings, once again open GridCliqueIt_Config.lua and look for function GridCliqueIt.LoadSettings(). Here you'll see where it sets up all the default settings. At the end of all of these add the following:

Source code

1
2
   defaultSettings['hidePartyRaid'] = "true"
   defaultSettings['hidePlayerRaid'] = "true"

I made these options default to "true" to hide the player and party UIs by default when in a raid. You can set them to false if you wish.

To change these settings in game, make sure the Separate Raid Settings is on, then when in a raid changes to the Hide Party UI and Hide Player UI should affect the raid version of the settings (again note that you must be in a raid for this to take effect as well as having the Separate Raid Settings on).

I don't think the other changes I suggested will cause problems, but if there is try commenting out those other changes (you can just put two dashes (--) in front of each line to do so).
2013... The year from hell....

10

Wednesday, July 4th 2012, 12:27am

The change you proposed for GridCliqueIt.ConfigCheckLoad() (right before my last post) actually worked perfectly :D. I joined a party earlier, and when someone converted it into a raid, there was no party UI. Hopefully this sticks, but I'll make the changes you listed in your last post as well, just in case. Thank you so much for helping with this issue, Peryl. You rock!

Edit: Okay, just to update - Dashing out the second change you suggested (thus making it nonexistent) brings back the issue of the party UI not disappearing when converted to a raid -- even with the last change added.

So it works perfectly with the first two additions, but the only problem I'm having now is that whenever I log in, the add-on is in the middle of my screen. For some reason, it's not saving its position now (i.e. dropping its saved location whenever I log out). All other settings are still saved, however. Could either of those first two changes have affected this? No big deal if it can't be fixed, though, I still very much prefer this to the party UI bug. I did try dashing out the second change, since I thought it had started after that one, but it still happened with that disabled.

Formerly Catorii, D/S/M of Faction.


Peryl

Intermediate

Posts: 313

Location: Elsewhere

  • Send private message

11

Wednesday, July 4th 2012, 2:19pm

Try commenting out the first change but not the other two. The first change was to attempt to fix a sync problem, but that may have been caused by the missing default settings.

The second change really just forces the default party and player UIs to be shown/hidden according to the current settings so it shouldn't affect how the settings are saved.

The third, as mentioned, adds in what appears to be missing default settings which may be part of the sync problem.

As to GCI not saving its settings, I'm not really sure what might cause this. I'll need to take another look (ahhh the joy of trying to figure out other peoples code :D)
2013... The year from hell....

12

Wednesday, July 4th 2012, 7:23pm

Quoted from "Peryl;543272"

(ahhh the joy of trying to figure out other peoples code :D)


Peryl, sometimes I think that it is what you live for :D

If this fixes the problem someone should post to the project page on Curse so that we can get this in the next update.

13

Wednesday, July 4th 2012, 11:08pm

GCI is 100% fixed now. Taking out the first change got rid of the issue with it not saving the location. Now there's no issue with it at all -- it saves settings and locations of the add-on for both normal parties and raid parties, and it no longer has the original issue with party UI not disappearing.

Thank you so much, Peryl, for looking at this code and finding ways to fix it. Healers everywhere will be grateful. :D

TL;DR - Use the second and third changes that Peryl came up with.

Formerly Catorii, D/S/M of Faction.


14

Wednesday, July 4th 2012, 11:15pm

Quoted from "effervescent;543379"

GCI is 100% fixed now. Taking out the first change got rid of the issue with it not saving the location. Now there's no issue with it at all -- it saves settings and locations of the add-on for both normal parties and raid parties, and it no longer has the original issue with party UI not disappearing.

Thank you so much, Peryl, for looking at this code and finding ways to fix it. Healers everywhere will be grateful. :D

TL;DR - Use the second and third changes that Peryl came up with.


Do you know if making these changes makes GCI work with Ikarus? :o Cause I would love to be able to use GCI again.
Borella - 100 W/M/S/R/P/K
VVV
If you play P/K in instances you're garbage


15

Wednesday, July 4th 2012, 11:50pm

Quoted from "Borella;543381"

Do you know if making these changes makes GCI work with Ikarus? :o Cause I would love to be able to use GCI again.


I don't have Ikarus set up right now, though I used to use it. I could re-install it tonight and see if it works, though. I would guess that since the party UI bug is fixed now, it won't have a problem with Ikarus anymore.

Edit: It does not appear to play nice with Ikarus, but it's been a long time since I used the add-on (and it was an older version), so I may have missed some setting that keeps the error from happening. The party UI bug seems to stick with Ikarus for some reason, whereas in vanilla RoM, the problem was totally fixed with Peryl's additions.

I didn't fool with it much though. So many options now o_o.

Formerly Catorii, D/S/M of Faction.


suprra

Professional

Posts: 932

Location: New Zealand

Occupation: Mechanic

Mood: Cursing

  • Send private message

16

Thursday, July 5th 2012, 3:40am

I use both and had the party frame bug for a lil bit, I first noticed it when I changed gci to individual char save, it kept on showing the blardy frames, so I changed it back to global save, later on that day I forgot about it, I crashed and it's been on individual save ever since and I've not had the bug again lol.

The only highly annoying thing we're noticing with gci is when zoning the frames will not update properly, i.e tank loses health, healer doesn't see my health bar change until he opens gci, saves and closes again. Doesn't happen every time, but once is too often :p

17

Thursday, July 5th 2012, 4:08am

So.. as some of you know im not the smartest, can someone update it for me and attach it somewhere. i have no clue how to do what you all are saying .. it's like *Brain freeze* kicks in. =[

as for with ikarus i never had an issue with ikarus and gci, the only issue im having is i actually been trying to do sw the past like 2 days and it only shows up maybe 3 people.. the rest are all invisible =[

Peryl

Intermediate

Posts: 313

Location: Elsewhere

  • Send private message

18

Thursday, July 5th 2012, 5:26am

Quoted from "effervescent;543379"

GCI is 100% fixed now. Taking out the first change got rid of the issue with it not saving the location. Now there's no issue with it at all -- it saves settings and locations of the add-on for both normal parties and raid parties, and it no longer has the original issue with party UI not disappearing.

Glad it worked.

Quoted from "effervescent;543390"

The party UI bug seems to stick with Ikarus for some reason, whereas in vanilla RoM, the problem was totally fixed with Peryl's additions.

Hmmmm... something else to look at then.

Quoted from "suprra;543431"

The only highly annoying thing we're noticing with gci is when zoning the frames will not update properly, i.e tank loses health, healer doesn't see my health bar change until he opens gci, saves and closes again. Doesn't happen every time, but once is too often :p

I guess this will be another thing to look into.

Quoted from "WhootyHoo;543433"

So.. as some of you know im not the smartest, can someone update it for me and attach it somewhere. i have no clue how to do what you all are saying .. it's like *Brain freeze* kicks in. =[

Well as Alterios mentioned, I or someone else can post these modifications to the project on Curseforge, but I haven't checked to see if it is still maintained. If not, I might post a version here.

Quoted from "WhootyHoo;543433"

as for with ikarus i never had an issue with ikarus and gci, the only issue im having is i actually been trying to do sw the past like 2 days and it only shows up maybe 3 people.. the rest are all invisible =[

Hmmmm... this might be something else. Have you tried it with the latest Ikarus?
2013... The year from hell....

Peryl

Intermediate

Posts: 313

Location: Elsewhere

  • Send private message

19

Friday, July 6th 2012, 1:42pm

Quoted from "suprra;543431"

The only highly annoying thing we're noticing with gci is when zoning the frames will not update properly, i.e tank loses health, healer doesn't see my health bar change until he opens gci, saves and closes again. Doesn't happen every time, but once is too often :p

Okay, lets see if this fixes the zoning problem. We'll be changing three files.

Open GridCliqueIt.xml and look for where it registers a bunch of events (they all start with this:RegisterEvent so should be easy to see). Add this to the list (doesn't matter where in the list you put it, just add it in there somewhere. I put it as the last one)

Source code

1
    this:RegisterEvent("ZONE_CHANGED")


Open GridCliqueIt_Variables.lua and right after the line GridCliqueIt.Version = "v0.24.1" add in this as a new line

Source code

1
GridCliqueIt.DoneLoading = false
[INDENT]Your code should now look like this (I also changed the version to indicate this is a modified version):

Source code

1
2
3
GridCliqueIt.Version = "v0.24.1(mod)"
GridCliqueIt.DoneLoading = false
GridCliqueIt.Frames = {}
[/INDENT]


Now open up GridCliqueIt.lua and at the end of the very first function (right before the end statement that starts at the far left) add the following:

Source code

1
2
3
4
5
6
7
   if event == "LOADING_END" then
      GridCliqueIt.DoneLoading = true
   end
   
   if event == "ZONE_CHANGED" and GridCliqueIt.DoneLoading then
      GridCliqueIt.UpDateFrames()
   end
[INDENT]Your code should now look like this:

Source code

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
   if event == "UNIT_PET_CHANGED" then
      GridCliqueIt.AddPets()
   end

   if event == "LOADING_END" then
      GridCliqueIt.DoneLoading = true
   end
   
   if event == "ZONE_CHANGED" and GridCliqueIt.DoneLoading then
      GridCliqueIt.UpDateFrames()
   end
end 


function GridCliqueIt.WaitForNamesComplete()
[/INDENT]
2013... The year from hell....